GCS: Add ability to configure http max connections and timeouts for gcs client. #15626
Open
mukund-thakur wants to merge 3 commits intoapache:mainfrom
Open
GCS: Add ability to configure http max connections and timeouts for gcs client. #15626mukund-thakur wants to merge 3 commits intoapache:mainfrom
mukund-thakur wants to merge 3 commits intoapache:mainfrom
Conversation
mukund-thakur
changed the title
mukund-thakur
changed the title
| public static final String GCS_ANALYTICS_CORE_ENABLED = "gcs.analytics-core.enabled"; | ||
|
|
||
| /** Optional configuration for connection timeout in milliseconds for GCS client. */ | ||
| public static final String GCS_CONNECTION_TIMEOUT_MILLIS = "gcs.connection.timeout-millis"; |
Contributor
There was a problem hiding this comment.
needs documentation in whichever file others are written up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15587
Initially I was only implementing above issue.
But later I found a way for #15411
This adds new configs to tune http connection parameters while while working with google cloud storage.
Please refer to gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java files for the added configurations.