Skip to content

Flink: Set forkEvery=1 on integration test to prevent worker JVM hang #15645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbonofre wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Flink: Set forkEvery=1 on integration test to prevent worker JVM hang #15645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions flink/v1.20/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
task integrationTest(type: Test) {
description = "Test Flink Runtime Jar against Flink ${flinkMajorVersion}"
group = "verification"
forkEvery = 1
Copy link
Copy Markdown
Contributor

@mxm mxm Mar 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one test which uses this task: TestIcebergConnectorSmoke (located in the flink-runtime module). The majority of the tests are located in the flink module.

We could add this flag under the test task (line 125), but we should keep an eye on the build time. I'm thinking it could go up by quite a bit (currently around 20 minutes).

Copy link
Copy Markdown
Member Author

@jbonofre jbonofre Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the one in particular which is problematic

Copy link
Copy Markdown
Member Author

@jbonofre jbonofre Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build time is the same today

Copy link
Copy Markdown
Contributor

@mxm mxm Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that one is the relevant test, then +1 for the change. How did we debug this? I'm curious because it is a bit hard to reproduce this. I've never run into the issue locally.

Copy link
Copy Markdown
Contributor

@Guosmilesmile Guosmilesmile Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m also curious how to reproduce this scenario—I haven’t hit this issue locally. If we can reproduce it, we can fix it more effectively.

If this addition doesn’t have a significant impact on the overall runtime, I think it’s fine to +1 for the change.

jvmArgs += project.property('extraJvmArgs')
testClassesDirs = sourceSets.integration.output.classesDirs
classpath = sourceSets.integration.runtimeClasspath + files(shadowJar.archiveFile.get().asFile.path)
Expand Down
1 change: 1 addition & 0 deletions flink/v2.0/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
task integrationTest(type: Test) {
description = "Test Flink Runtime Jar against Flink ${flinkMajorVersion}"
group = "verification"
forkEvery = 1
jvmArgs += project.property('extraJvmArgs')
testClassesDirs = sourceSets.integration.output.classesDirs
classpath = sourceSets.integration.runtimeClasspath + files(shadowJar.archiveFile.get().asFile.path)
Expand Down
1 change: 1 addition & 0 deletions flink/v2.1/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
task integrationTest(type: Test) {
description = "Test Flink Runtime Jar against Flink ${flinkMajorVersion}"
group = "verification"
forkEvery = 1
jvmArgs += project.property('extraJvmArgs')
testClassesDirs = sourceSets.integration.output.classesDirs
classpath = sourceSets.integration.runtimeClasspath + files(shadowJar.archiveFile.get().asFile.path)
Expand Down
Loading