Core: Coalesce contiguous blob reads in PuffinReader#15649
Open
hemanthboyina wants to merge 2 commits intoapache:mainfrom
Open
Core: Coalesce contiguous blob reads in PuffinReader#15649hemanthboyina wants to merge 2 commits intoapache:mainfrom
hemanthboyina wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PuffinReader.readAll() currently issues a separate seek+read for each blob. Since blobs are written back-to-back in a Puffin file, this results in unnecessary I/O overhead. This PR coalesces contiguous blobs into a single read. Blobs are sorted by offset, grouped into ranges where adjacent blobs touch, and each range is read in one I/O call.