Add manifest partition pruning to DV validation in MergingSnapshotProducer#15653
Open
anoopj wants to merge 1 commit intoapache:mainfrom
Open
Add manifest partition pruning to DV validation in MergingSnapshotProducer#15653anoopj wants to merge 1 commit intoapache:mainfrom
anoopj wants to merge 1 commit intoapache:mainfrom
Conversation
validateAddedDVs currently opens every delete manifest regardless of the conflict detection filter. This PR adds manifest evaluator-based filtering, skipping manifests that can't contain matching partitions. Note that other code paths use ManifestGroup, which already does this filtering. validateAddedDVs() was the only gap where we didn't filter.
anoopj
force-pushed
the
validation-partition-pruning
branch
from
b145372 to
0caa787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateAddedDVs()currently opens every delete manifest regardless of the conflict detection filter. This PR adds manifest evaluator-based filtering, skipping manifests that can't contain matching partitions.Note that other code paths in the snapshot producer uses
ManifestGroup, which already does this filtering. validateAddedDVs() was the only gap where we didn't filter.