Core: Sent minRowsRequested to REST server#15661
Merged
nastra merged 2 commits intoapache:mainfrom Mar 17, 2026
Merged
Conversation
nastra
force-pushed
the
min-rows-requested
branch
from
7fff099 to
fc8e0e0
Compare
pvary
approved these changes
Mar 17, 2026
singhpk234
approved these changes
Mar 17, 2026
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, thanks @nastra !
huaxingao
approved these changes
Mar 17, 2026
Contributor
Author
|
thanks everyone for the quick reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagates the
minRowsRequestedhint fromRESTTableScanto the REST scan planning server. Previously, this value was set on the scan context but never included in the planning request, so the server had no way to act on it.After introducing
minRowsRequestedin #14615, I forgot to follow-up and set it inRESTTableScanas well, since back then the scan planning wasn't merged yet.