Docs: Fix duplicate 'type' key in Nessie Flink Python example#17091
Open
thswlsqls wants to merge 1 commit into
Open
Docs: Fix duplicate 'type' key in Nessie Flink Python example#17091thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
The Flink Python API CREATE CATALOG example set the 'type' key twice
('iceberg' then 'nessie') in the same properties map. The repo's
established convention (see flink.md) is 'type'='iceberg' plus
'catalog-type'='nessie' to select the Nessie catalog implementation.
Generated-by: Claude Code
ebyhr
approved these changes
Jul 3, 2026
ebyhr
reviewed
Jul 3, 2026
| table_env.execute_sql("CREATE CATALOG nessie_catalog WITH (" | ||
| "'type'='iceberg', " | ||
| "'type'='nessie', " | ||
| "'catalog-type'='nessie', " |
Member
There was a problem hiding this comment.
Does this example really work? I think Flink only supports hadoop, hive, rest in catalog-type property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17089
Summary
CREATE CATALOGexample set the'type'key twice in the same properties map ('iceberg'then'nessie').flink.md) is'type'='iceberg'plus a separate'catalog-type'='<impl>'key to select the catalog implementation.'type'='nessie'to'catalog-type'='nessie'. A prior fix attempt, PR Docs: fix create nessie catalog in Flink #12978, proposed the same change but was closed by stale-bot with no merit objection; this bug is still present onmain.Testing done
docs/docs/flink.mdline 189-197'stype/catalog-typeconvention.