Skip to content

Docs: Fix duplicate 'type' key in Nessie Flink Python example#17091

Open
thswlsqls wants to merge 1 commit into
apache:mainfrom
thswlsqls:fix/nessie-flink-python-duplicate-type-key
Open

Docs: Fix duplicate 'type' key in Nessie Flink Python example#17091
thswlsqls wants to merge 1 commit into
apache:mainfrom
thswlsqls:fix/nessie-flink-python-duplicate-type-key

Conversation

@thswlsqls

Copy link
Copy Markdown
Contributor

Closes #17089

Summary

  • The Flink Python API CREATE CATALOG example set the 'type' key twice in the same properties map ('iceberg' then 'nessie').
  • The repo's established convention (flink.md) is 'type'='iceberg' plus a separate 'catalog-type'='<impl>' key to select the catalog implementation.
  • Changed the second 'type'='nessie' to 'catalog-type'='nessie'. A prior fix attempt, PR Docs: fix create nessie catalog in Flink #12978, proposed the same change but was closed by stale-bot with no merit objection; this bug is still present on main.

Testing done

  • Docs-only change, no behavior change — no test added. Verified against docs/docs/flink.md line 189-197's type/catalog-type convention.

The Flink Python API CREATE CATALOG example set the 'type' key twice
('iceberg' then 'nessie') in the same properties map. The repo's
established convention (see flink.md) is 'type'='iceberg' plus
'catalog-type'='nessie' to select the Nessie catalog implementation.

Generated-by: Claude Code
@github-actions github-actions Bot added the docs label Jul 3, 2026
Comment thread docs/docs/nessie.md
table_env.execute_sql("CREATE CATALOG nessie_catalog WITH ("
"'type'='iceberg', "
"'type'='nessie', "
"'catalog-type'='nessie', "

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this example really work? I think Flink only supports hadoop, hive, rest in catalog-type property.

String catalogType = properties.getOrDefault(ICEBERG_CATALOG_TYPE, ICEBERG_CATALOG_TYPE_HIVE);
switch (catalogType.toLowerCase(Locale.ENGLISH)) {
case ICEBERG_CATALOG_TYPE_HIVE:
// The values of properties 'uri', 'warehouse', 'hive-conf-dir' are allowed to be null, in
// that case it will
// fallback to parse those values from hadoop configuration which is loaded from classpath.
String hiveConfDir = properties.get(HIVE_CONF_DIR);
String hadoopConfDir = properties.get(HADOOP_CONF_DIR);
Configuration newHadoopConf = mergeHiveConf(hadoopConf, hiveConfDir, hadoopConfDir);
return CatalogLoader.hive(name, newHadoopConf, properties);
case ICEBERG_CATALOG_TYPE_HADOOP:
return CatalogLoader.hadoop(name, hadoopConf, properties);
case ICEBERG_CATALOG_TYPE_REST:
return CatalogLoader.rest(name, hadoopConf, properties);
default:
throw new UnsupportedOperationException(
"Unknown catalog-type: " + catalogType + " (Must be 'hive', 'hadoop' or 'rest')");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Fix duplicate 'type' key in Nessie Flink Python example

2 participants