-
Notifications
You must be signed in to change notification settings - Fork 210
feat(python): add AsyncIterator interface to IggyConsumer #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cstruct
wants to merge
3
commits into
apache:master
Choose a base branch
from
cstruct:extend-consumer-group-interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| use std::sync::Arc; | ||
|
|
||
| use futures::StreamExt; | ||
| use iggy::prelude::IggyConsumer as RustIggyConsumer; | ||
| use pyo3::exceptions::PyStopIteration; | ||
|
|
||
| use crate::receive_message::ReceiveMessage; | ||
| use pyo3::prelude::*; | ||
| use pyo3_async_runtimes::tokio::future_into_py; | ||
| use tokio::sync::Mutex; | ||
|
|
||
| #[pyclass] | ||
| pub struct ReceiveMessageIterator { | ||
| pub(crate) inner: Arc<Mutex<RustIggyConsumer>>, | ||
| } | ||
|
|
||
| #[pymethods] | ||
| impl ReceiveMessageIterator { | ||
| pub fn __anext__<'a>(&self, py: Python<'a>) -> PyResult<Bound<'a, PyAny>> { | ||
| let inner = self.inner.clone(); | ||
| future_into_py(py, async move { | ||
| let mut inner = inner.lock().await; | ||
| if let Some(message) = inner.next().await { | ||
| Ok(message | ||
| .map(|m| ReceiveMessage { | ||
| inner: m.message, | ||
| partition_id: m.partition_id, | ||
| }) | ||
| .map_err(|e| { | ||
| PyErr::new::<pyo3::exceptions::PyRuntimeError, _>(format!("{e:?}")) | ||
| })?) | ||
| } else { | ||
| Err(PyStopIteration::new_err("No more messages")) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| pub fn __aiter__(slf: PyRef<'_, Self>) -> PyRef<'_, Self> { | ||
| slf | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any problem making this
__aiter__?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, I thought about it as well but landed on having a
itermethod because I thought it read better. I don't have strong feelings about this so am open to changing it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this again and now I think it's better not to allow users to iterate through the consumer itself as that can be confusing. This
itermethod can probably be named asread_messagesfor clarity as it seems to be reading messages only instead of consuming them.Also, what is the expected behaviour?
If this method changes the consumer state, we need to make this clear.