IGNITE-24156 Tx states overconsume heap #5252
Open
+48
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vldpyatkov
force-pushed
the
ignite-24156
branch
from
0e283c9 to
7b339d1
Compare
| } | ||
|
|
||
| long current = FastTimestamps.coarseCurrentTimeMillis(); | ||
|
|
There was a problem hiding this comment.
remove one empty line
| @@ -171,39 +170,34 @@ public CompletableFuture<Void> vacuum( | |||
| } else if (TxState.isFinalState(meta0.txState())) { | |||
| Long initialVacuumObservationTimestamp = meta0.initialVacuumObservationTimestamp(); | |||
There was a problem hiding this comment.
why still Long? maybe make initialVacuumObservationTimestamp() not nullable and add requireNonNull here?
There was a problem hiding this comment.
It still can be null for not final tx states.
| @@ -171,39 +170,34 @@ public CompletableFuture<Void> vacuum( | |||
| } else if (TxState.isFinalState(meta0.txState())) { | |||
| Long initialVacuumObservationTimestamp = meta0.initialVacuumObservationTimestamp(); | |||
|
|
|||
| if (initialVacuumObservationTimestamp == null && txnResourceTtl > 0) { | |||
| markedAsInitiallyDetectedTxnsCount.incrementAndGet(); | |||
There was a problem hiding this comment.
markedAsInitiallyDetectedTxnsCount is it still needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24156