-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: raft implements domain name resolution and selects peerId #7181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is not a bugfix PR because, according to the changes you listed, the first point is a feature and the second point is an optimization.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7181 +/- ##
============================================
- Coverage 52.20% 52.06% -0.15%
- Complexity 6817 6855 +38
============================================
Files 1154 1169 +15
Lines 41116 41461 +345
Branches 4820 4850 +30
============================================
+ Hits 21464 21585 +121
- Misses 17611 17822 +211
- Partials 2041 2054 +13
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
raft不设置SEATA_IP,raft实现域名解析并选择peerId
Ⅱ. Does this pull request fix one issue?
#7082
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews