Remove the logic of memtable flush controlled by memory series size #13653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13653 +/- ##
============================================
+ Coverage 39.79% 39.84% +0.05%
Complexity 71 71
============================================
Files 4159 4159
Lines 263425 263409 -16
Branches 32083 32085 +2
============================================
+ Hits 104818 104963 +145
+ Misses 158607 158446 -161 ☔ View full report in Codecov by Sentry. |
HTHou
changed the title
HTHou
changed the title
jt2594838
approved these changes
Oct 15, 2024
...main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AlignedWritableMemChunk.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AlignedWritableMemChunk.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AlignedWritableMemChunk.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/IWritableMemChunk.java
Outdated
Show resolved
Hide resolved
...ode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java
Outdated
Show resolved
Hide resolved
...de/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/WritableMemChunk.java
Outdated
Show resolved
Hide resolved
...de/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/WritableMemChunk.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/AlignedTVList.java
Outdated
Show resolved
Hide resolved
jt2594838
approved these changes
Oct 16, 2024
jt2594838
approved these changes
Oct 18, 2024
| @@ -58,7 +58,7 @@ public class AlignedWritableMemChunk implements IWritableMemChunk { | |||
|
|
|||
| private static final IoTDBConfig CONFIG = IoTDBDescriptor.getInstance().getConfig(); | |||
| private final long TARGET_CHUNK_SIZE = CONFIG.getTargetChunkSize(); | |||
| private final long MAX_NUMBER_OF_POINTS_IN_CHUNK = CONFIG.getAvgSeriesPointNumberThreshold(); | |||
| private long MAX_NUMBER_OF_POINTS_IN_CHUNK = CONFIG.getTargetChunkPointNum(); | |||
There was a problem hiding this comment.
Now that it is not final, its capitalization would better be changed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, if the row number of a memory chunk exceeded the
avgSeriesPointNumberThreshold, or the size of a binary type memory chunk exceeded thetargetChunkSize, this memory chunk will split to multiple disk chunks in the TsFile.