Fix non-determinism in test - AlignByDeviceOrderByLimitOffsetTest#orderByExpressionTest1 #13961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test
org.apache.iotdb.db.queryengine.plan.planner.distribution.AlignByDeviceOrderByLimitOffsetTest#orderByExpressionTest1
fails under NonDex tool which detects non-deterministic nature of tests with when non-deterministic data structures are used. The failure behavior is defined by incorrect ordering ofrelatedDataRegions
.relatedDataRegions
is a hashset and hence doesn't have deterministic order as per the java documentation, but is iterated over in the methodconstructDeviceViewNodeListWithCrossRegion
.How to Reproduce
Error
Proposed Solution
Use
LinkedHashSet
instead ofHashSet
to keep the ordering deterministicPlease let me know if you have any questions or need any additional justification/changes from my side.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR