[region migration] Fix sync lag metric during add region #13995
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HxpSerein
reviewed
Nov 7, 2024
| @@ -844,8 +844,7 @@ public long getSearchIndex() { | |||
| } | |||
|
|
|||
| public long getSyncLag() { | |||
| long minSyncIndex = getMinSyncIndex(); | |||
| return getSearchIndex() - minSyncIndex; | |||
| return getSearchIndex() - getMinFlushedSyncIndex(); | |||
There was a problem hiding this comment.
It is recommended to use a local variable as before. Because the two get operation is not an atomic operation, subtracting the two function may result in a negative number.
There was a problem hiding this comment.
- getMinFlushedSyncIndex() + getSearchIndex() looks better :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid this:
