Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all push-able expressions in push down to metaData & Optimized database-related error logs #14093

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Caideyipi
Copy link
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link
Contributor

@JackieTien97 JackieTien97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to ColumnTransformerBuilder or IrExpressionInterpreter.Visitor to refactor the Checker, directly extends AstVisitor instead of the strange PredicateVisitor.

@Caideyipi Caideyipi changed the title Support nested function call in push down to metaData Support all push-able expressions in push down to metaData Nov 14, 2024
@Caideyipi Caideyipi changed the title Support all push-able expressions in push down to metaData Support all push-able expressions in push down to metaData & Optimized database-related error logs Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants