-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[to dev/1.3] Fix slow query threshold & fix a bug for lastQuery & optimize encodeBatch for multi tvlist scene #16766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/1.3 #16766 +/- ##
=============================================
- Coverage 41.04% 41.04% -0.01%
Complexity 198 198
=============================================
Files 3586 3589 +3
Lines 235277 235685 +408
Branches 28388 28452 +64
=============================================
+ Hits 96571 96733 +162
- Misses 138706 138952 +246 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Caideyipi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JackieTien97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz fix the sonar and code coverage, otherwise it won't be merged
…ngine/dataregion/memtable/AlignedTVListIteratorTest.java Co-authored-by: Copilot <[email protected]>
|

Description
#16765
Description
Default slowQueryThreshold should be 10s
optimize encodeBatch for multi tvlist scene
Scenario
Rows: 0–99999 (100,000 rows)
Duplicate timestamps occur at only two positions:
index 123
index 90732
Using regular BitMap
Must allocate 100,000 bits immediately.
Even though only 2 bits will be marked.
Using LazyBitMap (blockSize = 10,000)
LazyBitMap creates blocks only when needed:
Block for index 123 → block index = 0
Block for index 90732 → block index = 90
Total allocated blocks: 2 blocks
Each block has only 10,000 bits, so memory is:
2 blocks × 10,000 bits = 20,000 bits total
Savings
Regular BitMap: 100,000 bits
LazyBitMap: 20,000 bits
➡ 80% memory reduction
➡ Matches the sparse nature of duplicated timestamps