OAK-6766: Convert oak-lucene to OSGi R7 annotations #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed handling of component property attribute.
mbaedke
changed the title
Simplified component property handling.
reschke
reviewed
Mar 11, 2024
Definitely
Now that I realized that they can be retrieved directly from the ComponentContext without needing a reference to the ConfigurationAdmin service (see last commit), I don't think it can get simpler anymore. |
Have you tried adding the private property names to the annotation, but leaving the |
kwin
reviewed
Mar 12, 2024
...src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java
Outdated
Show resolved
Hide resolved
|
@jsedding Yes, I tried that :) |
kwin
reviewed
Mar 12, 2024
...src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java
Outdated
Show resolved
Hide resolved
kwin
reviewed
Mar 12, 2024
...src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java
Outdated
Show resolved
Hide resolved
Removed redundant type conversions. Replaced component properties with comfiguration type methods.
|
Addressed @kwin 's suggestions. |
Added missing bind/unbind attribute to reference annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.