KAFKA-18017: Fix call order for HB error and group manager #17805
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @chia7712 , any chance you could take a look at this small fix? Thanks! |
|
@lianetm Thanks for the patch. The fix makes sense to me. Could you open a JIRA for it since it's a bug fix? Additionally, should we also fix |
lianetm
changed the title
|
Hi @chia7712, added the fix and test to the onFailure path too, good catch. Thanks for the review! |
kirktrue
added
the
KIP-848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to ensure that the group manager is notified about HB errors only after having propagated the error to the app thread via en ErrorEvent. This is to ensure that the app thread is aware of the error if ever there is an ongoing unsubscribe operation processing background events in the app thread.