KAFKA-18011: Remove ZooKeeper sections from the docs #17813
+47
−887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimaison
commented
Nov 14, 2024
| @@ -1,34 +0,0 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
As far as I can tell this page is not accessible on the website. Anyway it's about Kafka 0.8!
mimaison
commented
Nov 14, 2024
| @@ -1213,41 +1213,7 @@ <h4 class="anchor-heading"><a id="multitenancy-more" class="anchor-link"></a><a | |||
| <strong>Data contracts:</strong> You may need to define data contracts between the producers and the consumers of data in a cluster, using event schemas. This ensures that events written to Kafka can always be read properly again, and prevents malformed or corrupt events being written. The best way to achieve this is to deploy a so-called schema registry alongside the cluster. (Kafka does not include a schema registry, but there are third-party implementations available.) A schema registry manages the event schemas and maps the schemas to topics, so that producers know which topics are accepting which types (schemas) of events, and consumers know how to read and parse events in a topic. Some registry implementations provide further functionality, such as schema evolution, storing a history of all schemas, and schema compatibility settings. | |||
| </p> | |||
|
|
|||
|
|
|||
| <h3 class="anchor-heading"><a id="config" class="anchor-link"></a><a href="#config">6.5 Kafka Configuration</a></h3> | |||
There was a problem hiding this comment.
This section was pretty much useless, it did not provide the important configuration names and the "example production server configuration" was really incomplete.
mimaison
commented
Nov 14, 2024
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| <script id="security-template" type="text/x-handlebars-template"> | |||
| <h3 class="anchor-heading"><a id="security_overview" class="anchor-link"></a><a href="#security_overview">7.1 Security Overview</a></h3> | |||
| In release 0.9.0.0, the Kafka community added a number of features that, used either separately or together, increases security in a Kafka cluster. The following security measures are currently supported: | |||
There was a problem hiding this comment.
I think we can remove this outdated sentence.
mimaison
commented
Nov 14, 2024
| @@ -1561,16 +1524,6 @@ <h4 class="anchor-heading"><a id="security_authz_examples" class="anchor-link">< | |||
| <pre><code class="language-bash">$ bin/kafka-acls.sh --bootstrap-server localhost:9092 --add --allow-principal User:Bob --consumer --topic Test-topic --group Group-1 </code></pre> | |||
| Note that for consumer option we must also specify the consumer group. | |||
| In order to remove a principal from producer or consumer role we just need to pass --remove option. </li> | |||
|
|
|||
| <li><b>Admin API based acl management</b><br> | |||
There was a problem hiding this comment.
All the commands above already use bootstrap-server so this section is not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining ZooKeeper bits (SCRAM) are to be done in https://issues.apache.org/jira/browse/KAFKA-18012
Committer Checklist (excluded from commit message)