KAFKA-17994: Checked exceptions are not handled #17817
Open
+48
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While Java distinguished between checked vs unchecked exception, other JVM languages do not. Thus, user code might still throw a checked exception even if no checked exception is declared on the implemented interface.
bbejeck
reviewed
Nov 14, 2024
| } | ||
| return stacktrace; | ||
| } | ||
|
|
There was a problem hiding this comment.
Unused method. side cleanup. (Sorry, should have called it out.)
| } catch (final RuntimeException processingException) { | ||
| } catch (final Exception processingException) { | ||
| // while Java distinguishes checked vs unchecked exceptions, other languages like | ||
| // Scala or Kotlin do no, and thus we need to `Exception` to work well with those languages |
There was a problem hiding this comment.
nit do no -> do not here and below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Java distinguished between checked vs unchecked exception, other JVM languages do not. Thus, user code might still throw a checked exception even if no checked exception is declared on the implemented interface.
Should be cherry-picked to 3.9 branch.