KAFKA-17561: KIP-1091 add operator metrics #17820
Open
+158
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbejeck
commented
Nov 14, 2024
| @@ -180,15 +180,16 @@ public void shouldPushMetricsToBroker(final String recordingLevel) throws Except | |||
| final String name = mn.name().replace('-', '.'); | |||
| final String group = mn.group().replace("-metrics", "").replace('-', '.'); | |||
| return "org.apache.kafka." + group + "." + name; | |||
| }).sorted().collect(Collectors.toList()); | |||
| }).filter(name -> !name.equals("org.apache.kafka.stream.thread.state"))// telemetry reporter filters out string metrics | |||
| .sorted().collect(Collectors.toList()); | |||
There was a problem hiding this comment.
Telemetry filters out string metrics, so I remove it here from the expected metrics list
mjsax
reviewed
Nov 15, 2024
| } else if (recordingLevelString.equals("DEBUG")) { | ||
| recordingLevel = 1; | ||
| } else { | ||
| // Must be TRACE level |
There was a problem hiding this comment.
Might be better to use another if and final else throw an exception as safe guard? Would also highlight that we need to update this code, in case we add a new level?
| private int calculateMetricsRecordingLevel() { | ||
| final int recordingLevel; | ||
| final String recordingLevelString = applicationConfigs.getString(METRICS_RECORDING_LEVEL_CONFIG); | ||
| if (recordingLevelString.equals("INFO")) { |
| @@ -614,6 +615,12 @@ public StreamThread(final Time time, | |||
| streamsMetrics, | |||
| time.milliseconds() | |||
| ); | |||
| ThreadMetrics.addThreadStateTelemetryMetric(threadId, | |||
There was a problem hiding this comment.
nit: threadId should be in the next line by itself
| ThreadMetrics.addThreadStateTelemetryMetric(threadId, | ||
| streamsMetrics, | ||
| (metricConfig, now) -> this.state().ordinal()); | ||
| ThreadMetrics.addThreadStateMetric(threadId, |
| (metricConfig, now) -> this.state().ordinal()); | ||
| ThreadMetrics.addThreadStateMetric(threadId, | ||
| streamsMetrics, | ||
| (metricConfig, now) -> this.state().name().toLowerCase(Locale.getDefault())); |
There was a problem hiding this comment.
For the corresponding client metric we just use
ClientMetrics.addStateMetric(streamsMetrics, (metricsConfig, now) -> state);
Why so "complicated" -- I am also ok to update the code for the client metric. But both should be the same?
(Or maybe keep ... -> state and add a "fancy" toString() overload to both enum (for client and thread) which model the state?
| final StreamsMetricsImpl streamsMetrics, | ||
| final Gauge<Integer> threadStateProvider) { | ||
| streamsMetrics.addThreadLevelMutableMetric( | ||
| THREAD_STATE, |
There was a problem hiding this comment.
nit: indention too deep (should only be 4 whitespace, not 8 -- should be an IDE setting)
| final StreamsMetricsImpl streamsMetrics, | ||
| final Gauge<String> threadStateProvider) { | ||
| streamsMetrics.addThreadLevelMutableMetric( | ||
| STATE, |
| final List<String> actualMetrics = new ArrayList<>(TelemetryPlugin.SUBSCRIBED_METRICS.get(mainConsumerInstanceId)); | ||
| assertEquals(expectedMetrics, actualMetrics); | ||
|
|
||
| TestUtils.waitForCondition(() -> !TelemetryPlugin.SUBSCRIBED_METRICS.get(adminInstanceId).isEmpty(), | ||
| 30_000, | ||
| "Never received subscribed metrics"); | ||
| final List<String> actualInstanceMetrics = TelemetryPlugin.SUBSCRIBED_METRICS.get(adminInstanceId); | ||
| final List<String> expectedInstanceMetrics = Arrays.asList("org.apache.kafka.stream.alive.stream.threads", "org.apache.kafka.stream.failed.stream.threads"); | ||
| final List<String> expectedInstanceMetrics = Arrays.asList("org.apache.kafka.stream.alive.stream.threads", "org.apache.kafka.stream.client.state", "org.apache.kafka.stream.failed.stream.threads", "org.apache.kafka.stream.recording.level"); |
There was a problem hiding this comment.
Nit: line too long. How about
final List<String> expectedInstanceMetrics = Arrays.asList(
"org.apache.kafka.stream.client.state",
"org.apache.kafka.stream.alive.stream.threads",
"org.apache.kafka.stream.failed.stream.threads",
"org.apache.kafka.stream.recording.level"
);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of KIP-1091 adding operator metrics to Kafka Streams
Updated existing tests to validate added metrics
Committer Checklist (excluded from commit message)