Skip to content

HOTFIX: Fix build issue due to alter offsets.#19794

Closed
smjn wants to merge 1 commit into
apache:trunkfrom
smjn:hotfix-build
Closed

HOTFIX: Fix build issue due to alter offsets.#19794
smjn wants to merge 1 commit into
apache:trunkfrom
smjn:hotfix-build

Conversation

@smjn

@smjn smjn commented May 23, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Collaborator

Build failing due to incompatible map type passed to
GroupMetadataManager.addInitializingTopicsRecords. Used util method to
wrap it.

Reviewers: wilmerdooley wilmer@snovon.com

@github-actions github-actions Bot added triage PRs from the community small Small PRs labels May 23, 2025
@smjn smjn requested a review from apoorvmittal10 May 23, 2025 10:41
@smjn smjn mentioned this pull request May 23, 2025
Merged
apoorvmittal10
apoorvmittal10 approved these changes May 23, 2025
View reviewed changes

@apoorvmittal10 apoorvmittal10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have another PR for hotfix: #19792. I am fine merging the other one and then correcting code, or merging this one directly.

@smjn

smjn commented May 23, 2025

Copy link
Copy Markdown
Collaborator Author

We have another PR for hotfix: #19792. I am fine merging the other one and then correcting code, or merging this one directly.

The other fix has unnecessary code.

@apoorvmittal10

apoorvmittal10 commented May 23, 2025

Copy link
Copy Markdown
Contributor

We have another PR for hotfix: #19792. I am fine merging the other one and then correcting code, or merging this one directly.

The other fix has unnecessary code.

Yeah, I understand. I was just saying that maybe we want the trunk to be fixed earlier. Hence we can correct the code after merging the other PR but anything is Ok with me.

@apoorvmittal10

apoorvmittal10 commented May 23, 2025

Copy link
Copy Markdown
Contributor

@mingyen066 @JimmyWang6

@apoorvmittal10

apoorvmittal10 commented May 23, 2025

Copy link
Copy Markdown
Contributor

@smjn I have merged the other PR for fixing trunk build. We shall discuss the better way in your PR, can you please update the PR, if needed.

@smjn smjn closed this May 23, 2025
@github-actions github-actions Bot removed the triage PRs from the community label May 24, 2025
@wilmerdooley

wilmerdooley commented Jun 18, 2026

Copy link
Copy Markdown

I opened #22610 to address this. The details are in the PR; happy to adjust based on what you'd prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorvmittal10 apoorvmittal10 apoorvmittal10 approved these changes

@AndrewJSchofield AndrewJSchofield AndrewJSchofield approved these changes

+1 more reviewer

@ShivsundarR ShivsundarR ShivsundarR approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-approved small Small PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smjn @apoorvmittal10 @wilmerdooley @AndrewJSchofield @ShivsundarR