KAFKA-19845: [1/N] Renew acks in share consumer #20838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJSchofield
changed the title
ShivsundarR
reviewed
Nov 11, 2025
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java
Outdated
Show resolved
Hide resolved
ShivsundarR
reviewed
Nov 11, 2025
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java
Outdated
Show resolved
Hide resolved
Contributor
adixitconfluent
left a comment
adixitconfluent
left a comment
There was a problem hiding this comment.
Looks good to me from the broker changes and integration tests perspective. One question though.
...nts-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java
Outdated
Show resolved
Hide resolved
apoorvmittal10
approved these changes
Nov 11, 2025
Contributor
apoorvmittal10
left a comment
apoorvmittal10
left a comment
There was a problem hiding this comment.
Thanks for the PR, LGTM.
adixitconfluent
approved these changes
Nov 11, 2025
Contributor
adixitconfluent
left a comment
adixitconfluent
left a comment
There was a problem hiding this comment.
LGTM for broker changes and integration tests
ShivsundarR
approved these changes
Nov 11, 2025
Contributor
ShivsundarR
left a comment
ShivsundarR
left a comment
There was a problem hiding this comment.
Thanks for the updated PR @AndrewJSchofield. Looks good to me.
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
Implements AcknowledgeType.RENEW in the share consumer as part of KIP-1222. There will be a future PR with additional tests. Reviewers: Apoorv Mittal <[email protected]>, Shivsundar R <[email protected]>, Abhinav Dixit <[email protected]>
shashankhs11
pushed a commit
to shashankhs11/kafka
that referenced
this pull request
Nov 14, 2025
Implements AcknowledgeType.RENEW in the share consumer as part of KIP-1222. There will be a future PR with additional tests. Reviewers: Apoorv Mittal <[email protected]>, Shivsundar R <[email protected]>, Abhinav Dixit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements AcknowledgeType.RENEW in the share consumer as part of
KIP-1222. There will be a future PR with additional tests.
Reviewers: Apoorv Mittal [email protected], Shivsundar R
[email protected], Abhinav Dixit [email protected]