MINOR: Clean up RemoteLogManagerTest.testCopyQuota #20853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
Contributor
Author
|
@chia7712 Hello, this is follow up I was talking about here: https://issues.apache.org/jira/browse/KAFKA-19578 |
UladzislauBlok
commented
Nov 10, 2025
Comment on lines
-3434
to
-3436
| if (quotaExceeded) { | ||
| assertEquals(Double.NaN, avgMetric.metricValue()); | ||
| assertEquals(Double.NaN, maxMetric.metricValue()); |
Contributor
Author
There was a problem hiding this comment.
Remove this code, because it's dead. We already verified this value here https://github.com/apache/kafka/pull/20853/files#diff-b1c88902ed00a1f69231484869415b83599a711d5e95dec19c396f0a350c31d9L3414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #20845
This PR brings clean up for dead code, and split parametrized
testCopyQuotainto two tests