KAFKA-19446: Add transaction version field [1/3] #20857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJSchofield
requested changes
Nov 10, 2025
Member
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Thanks for the PR. A couple of minor comments only.
clients/src/main/resources/common/message/WriteTxnMarkersRequest.json
Outdated
Show resolved
Hide resolved
AndrewJSchofield
changed the title
Member
|
@rreddy-22 Please merge latest changes from trunk. I'm not inclined to merge unless the build is green. |
…transaction-version-field
AndrewJSchofield
approved these changes
Nov 12, 2025
shashankhs11
pushed a commit
to shashankhs11/kafka
that referenced
this pull request
Nov 14, 2025
Simple PR to add the transaction version field to the WriteTxnMarkers Request in order to enable KIP-1228. We are bumping the API version to version 2. Reviewers: Artem Livshits <[email protected]>, Andrew Schofield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to add the transaction version field to the WriteTxnMarkers
Request in order to enable KIP-1228. We are bumping the API version to
version 2.
Reviewers: Artem Livshits [email protected], Andrew Schofield
[email protected]