KAFKA-19884: Add tests to ensure Consumer.close() timeouts work as documented #20872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cumented Ensure that close() takes at least DEFAULT_FETCH_MAX_WAIT_MS milliseconds to close, and ensure that close(CloseOptions) with a short timeout closes before DEFAULT_FETCH_MAX_WAIT_MS.
github-actions
bot
added
triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
close()takes at leastDEFAULT_FETCH_MAX_WAIT_MSmilliseconds to close, and ensure thatclose(CloseOptions)with a short timeout closes beforeDEFAULT_FETCH_MAX_WAIT_MS.