KAFKA-19583: fix: enable oauthbearer sasl with native image#22599
Open
wilmerdooley wants to merge 1 commit into
Open
KAFKA-19583: fix: enable oauthbearer sasl with native image#22599wilmerdooley wants to merge 1 commit into
wilmerdooley wants to merge 1 commit into
Conversation
…BEARER mechanism Signed-off-by: wilmerdooley <wilmerdooley1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native Kafka image fails to start when
KAFKA_SASL_ENABLED_MECHANISMS=OAUTHBEARERis configured because GraalVM native-image reachability metadata does not retain the no-argument constructors used by the reflective instantiation inLoginManagerand the SASL provider factories. This avoids the failure by instantiating the known login, callback handler, and SASL factory classes directly rather than viaUtils.newInstance/Provider.put, ensuring they are reachable in the native image.Changes:
LoginManager: introducecreateLoginandcreateLoginCallbackHandlerhelpers that directly instantiateDefaultLogin,KerberosLogin,OAuthBearerRefreshingLogin,AbstractLogin.DefaultLoginCallbackHandler, andOAuthBearerUnsecuredLoginCallbackHandler, falling back toUtils.newInstancefor any other class.OAuthBearerSaslClientProviderandOAuthBearerSaslServerProvider: register their services viaputServicewith an overriddennewInstancethat constructs the factory directly, instead of registering the class name and relying onProviderto instantiate it reflectively.Delete this text and replace it with a detailed description of your change. The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some commentary, upload images, or
include other supplemental information that should not be part of the eventual
commit message, please use a separate comment.
If applicable, please include a summary of the testing strategy (including
rationale) for the proposed change. Unit and/or integration tests are expected
for any behavior change and system tests should be considered for larger
changes.
JIRA: https://issues.apache.org/jira/browse/KAFKA-19583