KAFKA-20710: Share coordinator - Fence stale periodic jobs#22603
Open
Shekharrajak wants to merge 2 commits into
Open
KAFKA-20710: Share coordinator - Fence stale periodic jobs#22603Shekharrajak wants to merge 2 commits into
Shekharrajak wants to merge 2 commits into
Conversation
Shekharrajak
commented
Jun 17, 2026
| */ | ||
| private volatile boolean shouldRunPeriodicJob; | ||
|
|
||
| private final AtomicLong periodicJobGeneration = new AtomicLong(); |
Contributor
Author
There was a problem hiding this comment.
protects duplicate timer chains - similar to epoch concept.
Shekharrajak
commented
Jun 17, 2026
| } | ||
|
|
||
| private boolean shouldRunPeriodicJob(long generation) { | ||
| return shouldRunPeriodicJob && periodicJobGeneration.get() == generation; |
Contributor
Author
There was a problem hiding this comment.
It must not start work if it belongs to old generation.
Shekharrajak
commented
Jun 17, 2026
|
|
||
| service.onMetadataUpdate(mock(MetadataDelta.class), enabledImage); | ||
| assertTrue(service.shouldRunPeriodicJob()); | ||
| verify(timer, times(4)).add(any()); |
Contributor
Author
There was a problem hiding this comment.
Without the fix, this became 6 because old prune and old snapshot completions each rescheduled one stale job.
Contributor
Author
There was a problem hiding this comment.
2(old) + 4(new)
Shekharrajak
commented
Jun 17, 2026
| .thenReturn(List.of(firstSnapshotFuture)) | ||
| .thenReturn(List.of(secondSnapshotFuture)); | ||
|
|
||
| service.startup(() -> 1); |
Contributor
Author
There was a problem hiding this comment.
two periodic jobs:
- record prune job: write-state-record-prune
- cold partition snapshot job: snapshot-cold-partitions
Shekharrajak
commented
Jun 17, 2026
| service.onMetadataUpdate(mock(MetadataDelta.class), enabledImage); | ||
|
|
||
| verify(timer, times(2)).add(any()); | ||
| timer.advanceClock(30001L); |
Contributor
Author
There was a problem hiding this comment.
manually advances mock time so the scheduled timer tasks fire
Shekharrajak
commented
Jun 17, 2026
|
|
||
| verify(timer, times(2)).add(any()); | ||
| timer.advanceClock(30001L); | ||
| verify(runtime, times(1)).scheduleWriteOperation( |
Contributor
Author
There was a problem hiding this comment.
both delayed tasks run once when we advance the timer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref https://issues.apache.org/jira/browse/KAFKA-20710
ShareCoordinatorServicewith a periodic-job generation guard so stale timer tasks and stale async completions cannot reschedule after disable/re-enable.