Skip to content

KAFKA-19717: fix(connect/transforms): preserve fractional digits in InsertHeader literal values #22609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wilmerdooley wants to merge 1 commit into
base: trunk
Choose a base branch
from
+41 −1
Open

KAFKA-19717: fix(connect/transforms): preserve fractional digits in InsertHeader literal values #22609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion connect/transforms/src/main/java/org/apache/kafka/connect/transforms/InsertHeader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@
import org.apache.kafka.common.config.ConfigDef;
import org.apache.kafka.common.utils.internals.AppInfoParser;
import org.apache.kafka.connect.connector.ConnectRecord;
import org.apache.kafka.connect.data.Schema;
import org.apache.kafka.connect.data.SchemaAndValue;
import org.apache.kafka.connect.data.Values;
import org.apache.kafka.connect.header.Headers;
import org.apache.kafka.connect.transforms.util.SimpleConfig;

import java.math.BigDecimal;
import java.util.Map;

import static org.apache.kafka.common.config.ConfigDef.NO_DEFAULT_VALUE;
Expand Down Expand Up @@ -78,6 +80,31 @@ public void close() {
public void configure(Map<String, ?> props) {
final SimpleConfig config = new SimpleConfig(CONFIG_DEF, props);
header = config.getString(HEADER_FIELD);
literalValue = Values.parseString(config.getString(VALUE_LITERAL_FIELD));
String rawValue = config.getString(VALUE_LITERAL_FIELD);
SchemaAndValue parsed = Values.parseString(rawValue);
if (parsed != null && parsed.schema() != null) {
Schema.Type type = parsed.schema().type();
boolean isIntegral = type == Schema.Type.INT8 || type == Schema.Type.INT16 || type == Schema.Type.INT32 || type == Schema.Type.INT64;
if (isIntegral && rawValue.contains(".")) {
try {
BigDecimal decimal = new BigDecimal(rawValue);
float fValue = decimal.floatValue();
double dValue = decimal.doubleValue();
if (fValue != Float.NEGATIVE_INFINITY && fValue != Float.POSITIVE_INFINITY) {
literalValue = new SchemaAndValue(Schema.FLOAT32_SCHEMA, fValue);
} else if (dValue != Double.NEGATIVE_INFINITY && dValue != Double.POSITIVE_INFINITY) {
literalValue = new SchemaAndValue(Schema.FLOAT64_SCHEMA, dValue);
} else {
literalValue = new SchemaAndValue(org.apache.kafka.connect.data.Decimal.schema(decimal.scale()), decimal);
}
} catch (NumberFormatException e) {
literalValue = parsed;
}
} else {
literalValue = parsed;
}
} else {
literalValue = parsed;
}
}
}
13 changes: 13 additions & 0 deletions connect/transforms/src/test/java/org/apache/kafka/connect/transforms/InsertHeaderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,19 @@ public void insertionWithByteHeader() {
assertEquals(expect, xformed.headers());
}

@Test
public void insertionWithFloatHeader() {
xform.configure(config("inserted", "2.0"));
ConnectHeaders headers = new ConnectHeaders();
headers.addString("existing", "existing-value");
Headers expect = headers.duplicate().addFloat("inserted", 2.0f);

SourceRecord original = sourceRecord(headers);
SourceRecord xformed = xform.apply(original);
assertNonHeaders(original, xformed);
assertEquals(expect, xformed.headers());
}

@Test
public void configRejectsNullHeaderKey() {
assertThrows(ConfigException.class, () -> xform.configure(config(null, "1")));
Expand Down