KAFKA-19092: Fix flaky testBalancePartitionLeaders by reducing check interval and increasing timeout#22621
Open
suryakantade wants to merge 1 commit into
Conversation
…interval and increasing timeout The test was failing ~3% of CI runs because the leader imbalance check interval (1s) combined with a 10x timeout multiplier left only a 10s window for the periodic "electPreferred" task to fire and rebalance. Under CI thread-scheduling jitter, this was insufficient. Changes: - Reduce leaderImbalanceCheckIntervalNs from 1s to 100ms so the periodic task fires more frequently, reducing sensitivity to thread-scheduling delays. - Increase the waitForCondition timeout multiplier from 10x to 100x (effectively 10s total), giving ample headroom for slow CI environments while keeping the test deterministic. - Add documentation explaining the test lifecycle and why the low check interval is necessary.
github-actions
Bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the flaky testBalancePartitionLeaders test that was failing ~3% of CI runs.
The root cause is a timing issue: the leader imbalance check interval (1s) combined with a 10× timeout multiplier left only a 10s window for the periodic electPreferred task to fire and rebalance partitions. Under CI thread-scheduling jitter (KafkaEventQueue uses real wall-clock cond.awaitNanos()), this was insufficient.
Changes
Jira: KAFKA-19092 (https://issues.apache.org/jira/browse/KAFKA-19092)