KNOX-3381: Fix HaDispatch unnecessary failover due to IOException dur…#1308
Merged
Conversation
…ing writeOutboundResponse
Test Results36 tests 36 ✅ 5s ⏱️ Results for commit e3e7dd4. |
smolnar82
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing writeOutboundResponse
KNOX-3381 - HADispatch retries on IOException during writeOutboundResponse
What changes were proposed in this pull request?
Failover dispatches wrapped both the backend call and the response-copy in one try, so an
IOExceptionwhile streaming an already-received response to the client (e.g. a parse/rewrite error) triggered a failover — replaying a request the backend had already served. Split the two phases so only backend-connection failures fail over; response-copy errors now propagate. Applied toConfigurableHADispatchand theAtlas/NiFiHA dispatches, plus a new test.Not touching
AbstractHdfsHaDispatchin this PR because it fails over on other exceptions as well.How was this patch tested?
Unit tests, tested locally with custom REST endpoints
Integration Tests
N/A
UI changes
N/A