Skip to content

Bump floor segment size to 16MB. #14189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2025
Merged

Bump floor segment size to 16MB. #14189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7bf6a7
Bump floor segment size to 16MB.
jpountz Feb 1, 2025
e1da7e0
CHANGES
jpountz Feb 1, 2025
3caaa1d
iter
jpountz Feb 2, 2025
662ac4b
Move CHANGES to 10.2
jpountz Feb 26, 2025
2d6a9bb
Merge branch 'main' into bump_floor_seg_size
jpountz Feb 26, 2025
2a31dc7
Merge branch 'main' into bump_floor_seg_size
jpountz Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,11 @@ Bug Fixes

* GITHUB#14215: Fix degenerate case in HNSW where all vectors have the same score. (Ben Trent)

Changes in Runtime Behavior
---------------------
* GITHUB#14189: Bump floor segment size to 16MB in TieredMergePolicy and
LogByteSizeMergePolicy. (Adrien Grand)

Other
---------------------

Expand Down
2 changes: 1 addition & 1 deletion lucene/core/src/java/org/apache/lucene/index/LogByteSizeMergePolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
public class LogByteSizeMergePolicy extends LogMergePolicy {

/** Default minimum segment size. @see setMinMergeMB */
public static final double DEFAULT_MIN_MERGE_MB = 1.6;
public static final double DEFAULT_MIN_MERGE_MB = 16;

/**
* Default maximum segment size. A segment of this size or larger will never be merged. @see
Expand Down
4 changes: 2 additions & 2 deletions lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public class TieredMergePolicy extends MergePolicy {

private long maxMergedSegmentBytes = 5 * 1024 * 1024 * 1024L;

private long floorSegmentBytes = 2 * 1024 * 1024L;
private long floorSegmentBytes = 16 * 1024 * 1024L;
private double segsPerTier = 10.0;
private double forceMergeDeletesPctAllowed = 10.0;
private double deletesPctAllowed = 20.0;
Expand Down Expand Up @@ -166,7 +166,7 @@ public double getDeletesPctAllowed() {
* </ul>
*
* In both cases, this helps prevent frequent flushing of tiny segments to create a long tail of
* small segments in the index. Default is 2MB.
* small segments in the index. Default is 16MB.
*/
public TieredMergePolicy setFloorSegmentMB(double v) {
if (v <= 0.0) {
Expand Down