Remove BitDocIdSet#bits method #14297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed DocIdSet#bits in apache#14290. This commit removes the last usage of the former bits method from QueryBitSetProducer. A BitSet can be used directly instead of a DocIdSet, introducind a sentinel that's specific to QueryBitSetProducer.
javanna
added a commit
to javanna/lucene
that referenced
this pull request
Feb 26, 2025
Same change as apache#14297, without the removal of the method, which is already deprecate in 10x.
javanna
added a commit
that referenced
this pull request
Feb 26, 2025
Same change as #14297, without the removal of the method, which is already deprecated in 10x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed DocIdSet#bits in #14290. This commit removes the last usage of the former bits method from QueryBitSetProducer. A BitSet can be used directly instead of a DocIdSet, introducing a sentinel that's specific to QueryBitSetProducer.