remove IndexReader.registerParentReader() #15002
Conversation
Remove this function and associated WeakhashMap: it is not needed any more. The tests still pass, user still gets ACE (just slightly different exception message). Closes apache#14999
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
There was a problem hiding this comment.
Looks OK.
IMHO we should not backport this and let it live for some time on main branch. I think the whole thing was only invented for MMapDirectory when closing child readers may sigsegv parent reader.
If we find this useful in main, we can backport it (in 10.x we have no MappedByteBuffer usage anymore). If we do this, maybe deprecate and make the public API | https://github.com/apache/lucene/pull/15002/files#diff-2f71663645c05d1d7a61c17ed8928715a4ef6c01b47fd19d488a51ade76bce1aL162 a noop.
lucene/core/src/test/org/apache/lucene/index/TestReaderClosed.java
Outdated
Show resolved
Hide resolved
|
I marked this for 11.0. Please add a changes.txt. |
Remove this function and associated WeakhashMap: it is not needed any more. The tests still pass, user still gets ACE (just slightly different exception message). Closes apache#14999
2 participants
Remove this function and associated WeakhashMap: it is not needed any more. The tests still pass, user still gets ACE (just slightly different exception message).
Closes #14999