Skip to content

[10.3] Fix returned Impacts when frequencies are not indexed #15263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2025
Merged

[10.3] Fix returned Impacts when frequencies are not indexed #15263

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
301d85d
Fix returned Impacts when frequencies are not indexed
iverase Sep 30, 2025
652d3ee
doh
iverase Sep 30, 2025
1ba118b
add test
iverase Sep 30, 2025
d3f00a9
Add entry in CHANGES.txt
iverase Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,9 @@
public final class Lucene103PostingsReader extends PostingsReaderBase {

static final VectorizationProvider VECTORIZATION_PROVIDER = VectorizationProvider.getInstance();
// Dummy impacts, composed of the maximum possible term frequency and the lowest possible
// (unsigned) norm value. This is typically used on tail blocks, which don't actually record
// impacts as the storage overhead would not be worth any query evaluation speedup, since there's
// less than 128 docs left to evaluate anyway.
private static final List<Impact> DUMMY_IMPACTS =
Collections.singletonList(new Impact(Integer.MAX_VALUE, 1L));

private static final List<Impact> DUMMY_IMPACTS_NO_FREQ =
Collections.singletonList(new Impact(1, 1L));

private final IndexInput docIn;
private final IndexInput posIn;
Expand Down Expand Up @@ -1382,7 +1379,8 @@ public List<Impact> getImpacts(int level) {
return readImpacts(level1SerializedImpacts, level1Impacts);
}
}
return DUMMY_IMPACTS;
// Max freq is 1 since freqs are not indexed
return DUMMY_IMPACTS_NO_FREQ;
}

private List<Impact> readImpacts(BytesRef serialized, MutableImpactList impactsList) {
Expand Down
Loading