-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Enable branch and tag protection. #15265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
protected_branches: | ||
main: {} | ||
branch_10x: {} | ||
branch_9x: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add all older branch_*
branches (maybe export the list from github) and in parallel ask infra how to setup this with a glob.
Maybe it works like:
protected_branches:
"branch_*": {}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can only try that out and try to force push as test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can try on a some test branch, maybe?
why does linting fail now, has to do with main branch problem? |
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
Let me take a look, weird. |
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
In yaml you can have quotes in keys, so globs should work. |
I'd say - let's merge this and then test on test_* if it works. |
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
I am in contact with ASF infra in slack channel! |
Fixes #15264
I didn't add all the past branch_* branches. Should I?