Skip to content

Conversation

dweiss
Copy link
Contributor

@dweiss dweiss commented Sep 30, 2025

Fixes #15264

I didn't add all the past branch_* branches. Should I?

Copy link
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

protected_branches:
main: {}
branch_10x: {}
branch_9x: {}
Copy link
Contributor

@uschindler uschindler Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add all older branch_* branches (maybe export the list from github) and in parallel ask infra how to setup this with a glob.

Maybe it works like:

protected_branches:
    "branch_*": {}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can only try that out and try to force push as test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try on a some test branch, maybe?

@uschindler
Copy link
Contributor

why does linting fail now, has to do with main branch problem?

Copy link
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@dweiss
Copy link
Contributor Author

dweiss commented Sep 30, 2025

Let me take a look, weird.

Copy link
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@uschindler
Copy link
Contributor

uschindler commented Sep 30, 2025

In yaml you can have quotes in keys, so globs should work.

@dweiss
Copy link
Contributor Author

dweiss commented Sep 30, 2025

I'd say - let's merge this and then test on test_* if it works.

Copy link
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@dweiss dweiss added the skip-changelog Apply to PRs that don't need a changelog entry, stopping the automated changelog check. label Sep 30, 2025
@dweiss dweiss added this to the 11.0.0 milestone Sep 30, 2025
@dweiss dweiss merged commit 6532130 into apache:main Sep 30, 2025
12 checks passed
@dweiss dweiss deleted the branch-protection branch September 30, 2025 16:09
@uschindler
Copy link
Contributor

I am in contact with ASF infra in slack channel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Apply to PRs that don't need a changelog entry, stopping the automated changelog check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up branch protection against force-pushes on main, branch_10x

2 participants