Use appropriate return type for byte vector specific cosineBody* functions #15293
+7
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Intermediate cast from
int
->float
->int
in the byte vector specificcosineBody
function(s) loses precision.This happens for integers >= 2^24, because IEEE 754 single-precision floats use 24 bits to represent the integer part.
For example, when
16777217
is cast tofloat
and back toint
, it yields16777216
.This also avoids CPU cycles related to casting.
VectorUtilBenchmark
shows minor but consistent speedup:main
This PR