minor change: code cleanup #15447
Open
minor change: code cleanup #15447
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors a loop over the fieldHash array in the flush method from an indexed for-loop to a for-each loop, making the code more concise and idiomatic.
Key changes:
- Replaced indexed for-loop with for-each loop for iterating over
fieldHasharray
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Map<String, TermsHashPerField> fieldsToFlush = new HashMap<>(); | ||
| for (int i = 0; i < fieldHash.length; i++) { | ||
| PerField perField = fieldHash[i]; | ||
| for (PerField perField : fieldHash) { |
There was a problem hiding this comment.
While this refactoring is valid, there are other identical loop patterns over fieldHash in the same file (e.g., in writePoints() at line 371 and writeDocValues() at line 409) that still use the indexed for-loop style. For consistency, consider refactoring those loops to use for-each as well, or keep all of them in the same style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor code cleanup
refactored the loop over
fieldHashin theflushmethod to use a for-each loop