Add relative path preference settings to PhpUnit #8478

adamturcsan · 2025-04-30T22:35:40Z

This checkbox gives boolean setting switching between two behaviour of passing test file paths to the PhpUnit command:

FALSE/Unchecked = Use absolute paths [Current behaviour]
TRUE/Checked = Use relative paths

[Edit]
Motivation:

I develop PHP projects in a completely containerized setup. This setting would allow me to use all the functionality with a custom runner script, without dealing with path mapping, or any kind of more robust runner configuration.

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

are all your own work, and you have the right to contribute them.
are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

Was this PR correctly labeled, did the right tests run? When did they run?
Is this PR squashed?
Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

php/php.phpunit/src/org/netbeans/modules/php/phpunit/preferences/PhpUnitPreferences.java

...hp.phpunit/src/org/netbeans/modules/php/phpunit/preferences/PhpUnitPreferencesValidator.java

tmysik · 2025-05-07T15:49:24Z

@adamturcsan, sorry for the delay! Overall, the changes look OK to me; please, look into my comments.

@junichi11, could you please verify it too?

Thank you.

junichi11 · 2025-05-09T05:55:11Z

I'm not feeling well, so please wait a bit, sorry...

tmysik · 2025-05-09T06:46:46Z

@junichi11 get well soon! 🤞

junichi11 · 2025-05-09T11:18:41Z

@tmysik Thank you, Tomas!

php/php.phpunit/src/org/netbeans/modules/php/phpunit/preferences/PhpUnitPreferences.java

php/php.phpunit/src/org/netbeans/modules/php/phpunit/commands/PhpUnit.java

php/php.phpunit/src/org/netbeans/modules/php/phpunit/preferences/PhpUnitPreferences.java

tmysik · 2025-05-15T13:05:35Z

@adamturcsan, since @junichi11 is not feeling well, please, look into my recent comments (sorry, I totally missed that!) and once resolved, I will approve and we can merge it. If Junichi finds any problem later, we can easily create a ticket and fix it.

Thank you.

junichi11 · 2025-05-15T13:36:18Z

I'm sorry I'm late...

@tmysik Thank you for the review!

@adamturcsan Could you provide an example project as a zip file to check this change?

junichi11 · 2025-05-15T13:39:40Z

@mbien Is this author name OK?

mbien · 2025-05-15T13:59:03Z

@mbien Is this author name OK?

i think so. The patch file is using mime encoding https://github.com/apache/netbeans/pull/8478.patch due to special characters which makes it look weird.

But if you look at it using git log you can see a proper name. Looks good to me. (online tool: https://ldu2.github.io/rfc2047/)

junichi11 · 2025-05-15T14:01:51Z

@mbien Thank you!

adamturcsan · 2025-05-15T15:05:43Z

I'm sorry I'm late...

@tmysik Thank you for the review!

@adamturcsan Could you provide an example project as a zip file to check this change?

SampleProject8478.zip

I hope this project is okay like this.

junichi11 · 2025-05-16T05:13:22Z

@adamturcsan Thanks. Could you write steps to run tests?

Extract the zip file
...
...

junichi11 · 2025-05-16T05:16:59Z

Vertical gaps are too large. So, please adjust and check them.

adamturcsan · 2025-05-16T08:20:09Z

@junichi11 Sure. So my use case is driven by a dockerized setup, so the project I sent need docker.

Extract zip
Open extracted directory
make run - this fires up the project via docker-compose
Open project in NetBeans
Right click on project -> Test (Alt+F6)

You might want to run the tests without NB, then pls run make run-test.

I also updated the gaps around the new checkbox.

junichi11 · 2025-05-19T04:49:22Z

@adamturcsan Thanks!
One question: Do you add the user to the docker group to run docker commands without sudo?

I've verified that we can run tests after I add the user to the docker group.

I also updated the gaps around the new checkbox.

Nice! Please squash commits as one commit and update the screenshot :)

Your example project will be beneficial for anyone wanting to use this option.

junichi11 · 2025-05-19T05:16:12Z

Nitpick: Maybe Signed-off-by: ....... is not necessary.

This checkbox gives boolean setting switching between two behaviour of passing test file paths to the PhpUnit command: FALSE = Use absolute paths [Current behaviour] TRUE = Use relative paths [Based on source root]

adamturcsan · 2025-05-19T06:34:52Z

@junichi11 Yes you're right, I forgot to mention the user.

I've squashed the commits, updated the screenshot and removed the signed-off part.

tmysik · 2025-05-19T07:14:44Z

Just checked it once more and I don't see any problem now. @adamturcsan, great job, thank you!

junichi11

Great! Thank you for your work :)

junichi11 · 2025-05-19T12:43:57Z

@tmysik Let's merge this if it's OK with you :)

tmysik · 2025-05-19T14:01:24Z

Yes, @adamturcsan, please merge this PR! 👍

junichi11 · 2025-05-19T14:09:08Z

@tmysik We have to merge this PR because @adamturcsan can't do it :)
OK. Merging.

tmysik · 2025-05-19T14:55:49Z

I see, sorry. I just wanted @adamturcsan to be more visible in the log history 🙂

junichi11 · 2025-05-19T15:02:57Z

@tmysik Need not apologize at all. I thought that you wanted to do that ;) Thanks!

adamturcsan · 2025-05-19T15:03:51Z

Thanks @junichi11 and @tmysik for the guidance and the review, this was my first PR here, so I can only hope I wasn't too much of a burden ❤️ 😅

junichi11 · 2025-05-19T15:07:56Z

@adamturcsan No problem :) Your PR was merged. Congrats🎉

tmysik · 2025-05-19T15:26:09Z

@adamturcsan any PR is welcome, thank you for your work and time!

adamturcsan marked this pull request as ready for review April 30, 2025 22:36

troizet added the PHP [ci] enable extra PHP tests (php/php.editor) label May 1, 2025

troizet requested review from tmysik and junichi11 May 2, 2025 03:50

tmysik reviewed May 7, 2025

View reviewed changes

php/php.phpunit/src/org/netbeans/modules/php/phpunit/preferences/PhpUnitPreferences.java Outdated Show resolved Hide resolved

tmysik reviewed May 7, 2025

View reviewed changes

...hp.phpunit/src/org/netbeans/modules/php/phpunit/preferences/PhpUnitPreferencesValidator.java Outdated Show resolved Hide resolved

tmysik reviewed May 7, 2025

View reviewed changes

...hp.phpunit/src/org/netbeans/modules/php/phpunit/preferences/PhpUnitPreferencesValidator.java Outdated Show resolved Hide resolved

adamturcsan force-pushed the phpunit-relative-testfile-path branch from 2cfb49c to 2525d5d Compare May 15, 2025 09:37

tmysik reviewed May 15, 2025

View reviewed changes

php/php.phpunit/src/org/netbeans/modules/php/phpunit/preferences/PhpUnitPreferences.java Outdated Show resolved Hide resolved

tmysik reviewed May 15, 2025

View reviewed changes

php/php.phpunit/src/org/netbeans/modules/php/phpunit/commands/PhpUnit.java Outdated Show resolved Hide resolved

tmysik reviewed May 15, 2025

View reviewed changes

php/php.phpunit/src/org/netbeans/modules/php/phpunit/preferences/PhpUnitPreferences.java Outdated Show resolved Hide resolved

junichi11 added this to the NB27 milestone May 15, 2025

adamturcsan force-pushed the phpunit-relative-testfile-path branch from 2525d5d to 4a3400c Compare May 15, 2025 15:09

junichi11 added the Need Squashing label May 19, 2025

Add relative path preference settings to PhpUnit

7e72192

This checkbox gives boolean setting switching between two behaviour of passing test file paths to the PhpUnit command: FALSE = Use absolute paths [Current behaviour] TRUE = Use relative paths [Based on source root]

adamturcsan force-pushed the phpunit-relative-testfile-path branch from 5554004 to 7e72192 Compare May 19, 2025 06:32

mbien removed the Need Squashing label May 19, 2025

junichi11 approved these changes May 19, 2025

View reviewed changes

junichi11 merged commit b53a8a4 into apache:master May 19, 2025
32 checks passed

Add relative path preference settings to PhpUnit #8478

Add relative path preference settings to PhpUnit #8478

Uh oh!

Conversation

adamturcsan commented Apr 30, 2025 • edited by mbien Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR approval and merge checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tmysik commented May 7, 2025

Uh oh!

junichi11 commented May 9, 2025

Uh oh!

tmysik commented May 9, 2025

Uh oh!

junichi11 commented May 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tmysik commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

junichi11 commented May 15, 2025

Uh oh!

junichi11 commented May 15, 2025

Uh oh!

mbien commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

junichi11 commented May 15, 2025

Uh oh!

adamturcsan commented May 15, 2025

Uh oh!

junichi11 commented May 16, 2025

Uh oh!

junichi11 commented May 16, 2025

Uh oh!

adamturcsan commented May 16, 2025

Uh oh!

junichi11 commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

junichi11 commented May 19, 2025

Uh oh!

adamturcsan commented May 19, 2025

Uh oh!

tmysik commented May 19, 2025

Uh oh!

junichi11 left a comment

Choose a reason for hiding this comment

Uh oh!

junichi11 commented May 19, 2025

Uh oh!

tmysik commented May 19, 2025

Uh oh!

junichi11 commented May 19, 2025

Uh oh!

Uh oh!

tmysik commented May 19, 2025

Uh oh!

junichi11 commented May 19, 2025

Uh oh!

adamturcsan commented May 19, 2025

Uh oh!

junichi11 commented May 19, 2025

Uh oh!

tmysik commented May 19, 2025

Uh oh!

Uh oh!

adamturcsan commented Apr 30, 2025 •

edited by mbien

Loading

tmysik commented May 15, 2025 •

edited

Loading

mbien commented May 15, 2025 •

edited

Loading

junichi11 commented May 19, 2025 •

edited

Loading