fixing formatter issues #8484
Open
fixing formatter issues #8484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
the
Java
mbien
reviewed
May 5, 2025
Comment on lines
2568
to
2572
| Boolean hasErrThenStatement = Optional.ofNullable(node.getThenStatement()) | ||
| .filter(it-> it instanceof ExpressionStatementTree) | ||
| .map(it -> ((ExpressionStatementTree)it).getExpression()) | ||
| .map(it-> (it instanceof ErroneousTree)) | ||
| .orElse(false); |
There was a problem hiding this comment.
boolean hasErrThenStatement = node.getThenStatement() instanceof ExpressionStatementTree tree
&& tree.getExpression() instanceof ErroneousTree;easier to read and probably less overhead too
Comment on lines
2575
to
2579
| var isPreviousIfTree = false; | ||
| var endPositionOfErrThenStatement = endPos; | ||
| for (var statment : parentStTree.getStatements()) { | ||
| if (isPreviousIfTree) { | ||
| var startPositionOfNextErrorStatement = (int) sp.getStartPosition(getCurrentPath().getCompilationUnit(), statment); |
There was a problem hiding this comment.
lets not use var here. int has 3 chars too - no need for extra obfuscation just to make the IDE draw the type as inline hint wasting space ;)
Makes it also easier to review without checking this out in NetBeans.
var is more interesting for collections with complex generics signatures etc.
There was a problem hiding this comment.
+1 Also statment -> statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
providing fix for issue
{}of braces are injected at the erroneous then part in IfTreesp.getStartPositionandsp.getEndPositionalways returns begining index for erroneous then statement