Fixes #8314 : Missing domainsfolder Setting for Payara Services Configuration #8542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Configuration
jGauravGupta
added
Java EE/Jakarta EE
mbien
reviewed
May 28, 2025
| @@ -74,6 +74,9 @@ protected boolean enable(Node[] activatedNodes) { | |||
| } | |||
|
|
|||
| private static boolean enableImpl(PayaraModule commonSupport) { | |||
| if (Boolean.TRUE.toString().equals(commonSupport.getInstanceProperties().get(PayaraModule.WSL_ATTR))) { | |||
There was a problem hiding this comment.
Boolean.parseBoolean() might be better for those checks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Payara Server Configuration Issue by Restoring
domainsfolderSupport in NetBeansThis PR addresses an issue introduced in NetBeans 25+ where the
domainsfolderattribute was unintentionally removed from Payara Server service configurations. As a result, users experienced broken server setups after accessing the service properties in the UI, since the domains directory could no longer be resolved.