NUTCH-3161 Address Sonarcloud High and Medium Security Hotspots#904
Open
lewismc wants to merge 3 commits intoapache:masterfrom
Open
NUTCH-3161 Address Sonarcloud High and Medium Security Hotspots#904lewismc wants to merge 3 commits intoapache:masterfrom
lewismc wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
Confirmed this PR addresses the security hotspots and passes tests. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR to address NUTCH-3161. This patch addresses following Security Hotspota
High
(false positives): Exclude plugin resource directories from analysis in
sonar-project.properties. No Java code lives inconf,data, orsampleundersrc/plugin/**, so these paths are excluded from scanning., andMedium
src/java/.../ParseOutputFormat.java): Replace regex" *, *"fordb.parsemeta.to.crawldbwith comma-split + trim ingetParseMetaToCrawlDBKeys(). AddTestParseOutputFormatwith tests for empty, single, comma-separated, trim, and empty-segment handling.metaPattern,charsetPattern, andcharsetPatternHTML5. Use linear string parsing inextractCharsetFromMeta()/extractCharsetValue()for HTML4 and HTML5 meta charset detection. AddtestExtractCharsetFromMetain existingTestHtmlParser.STRING_PATTERNandURI_PATTERN. UseextractQuotedStrings()andlooksLikeUri()(linear scan / simple checks). AddtestExtractQuotedStringsandtestLooksLikeUriin existingTestJSParseFilter.URL_PATTERNandAUTHORITY_PATTERN. Usejava.net.URIfor URL structure andparseAuthority()for host/port. Remove unusedisBlankOrNull. AddtestParseAuthorityin existingTestUrlValidator.Thanks for any review.