-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/ci: Switch kconfig-frontend to kconfiglib #8504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
577f20b
to
3eb996b
Compare
btashton
requested changes
Feb 11, 2023
3eb996b
to
d667c5c
Compare
ccf58e0
to
4bc44c6
Compare
Signed-off-by: Xiang Xiao <[email protected]>
Signed-off-by: Xiang Xiao <[email protected]>
…lp text Signed-off-by: Xiang Xiao <[email protected]>
Signed-off-by: Xiang Xiao <[email protected]> Co-authored-by: chao an <[email protected]>
anchao
approved these changes
Feb 16, 2023
xiaoxiang781216
commented
Feb 16, 2023
Purge warning: Kconfig:249: warning: the 'modules' option is not supported. Let me know if this is a problem for you, as it wouldn't be that hard to implement. Note that modules are supported -- Kconfiglib just assumes the symbol name MODULES, like older versions of the C implementation did when 'option modules' wasn't used. Signed-off-by: chao an <[email protected]>
GUIDINGLI
approved these changes
Feb 17, 2023
@xiaoxiang781216 @anchao - this broke "make menuconfig" see #8557 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow #8494
kconfiglib can catch more error than kconfig-frontend: #8485
Impact
build system
Testing
CI