-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/services/gdrive): Fix gdrive create_dir request: trim trailing /
#4732
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 1260920.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi, have you tested locally about this PR? Our CI doesn't cover forked repo. |
I'm testing right now in https://infoflow.app 's alpha version. Will get back to you tomorrow |
Cool! |
correction: it is a regression cause by my change. investigating. |
the duplication problem got fixed. I ran behavior test locally but found many other issues:
Edit: This seems to be a dir name issue:
|
Hi @Xuanwo , I'll need to re-prioritize my tasks of my own company first. So I decided to mark this PR as draft first. Please feel free to close this PR if anybody else wants to take over the fix of Google Drive. To help the community fix the problem. Let me share the bugs I found for Google Drive on main:
Test logs on main``` ➜ core git:(main-test) ✗ OPENDAL_TEST=gdrive cargo test behavior --features tests --features services-gdrive -- --nocaptureCompiling opendal v0.47.1 (/Volumes/QuickMac/temp/202406/opendal/core) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 130 filtered out; finished in 0.00s
running 114 tests failures: ---- behavior::test_list_sub_dir ---- ---- behavior::test_list_dir_with_file_path ---- ---- behavior::test_list_nested_dir ---- ---- behavior::test_list_file_with_recursive ---- ---- behavior::test_blocking_list_dir_with_metakey_complete ---- ---- behavior::test_blocking_list_dir_with_recursive ---- ---- behavior::test_blocking_list_dir_with_recursive_no_trailing_slash ---- failures: test result: FAILED. 107 passed; 7 failed; 0 ignored; 0 measured; 0 filtered out; finished in 142.99s error: test failed, to rerun pass
|
Per discussion #4722
We have to remove
/
at the end of name