-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use tuple style struct in C binding #5167
base: main
Are you sure you want to change the base?
Conversation
the change in readme: https://stackoverflow.com/a/21594/13040423 |
Fair enough to move forward in my opinion. What do you think? @Xuanwo @yuchanns @xyjixyjixyji |
It seems like it's just changing from Does it make a difference in understanding or performance in a public API on the C side? |
+1 Does it impact the performance? |
no. Tuple style is just a syntax sugar that has |
So we may suspend this request and perhaps review it again before we build the release process for the C binding. |
IMO |
Which issue does this PR close?
Closes #5161
Rationale for this change
What changes are included in this PR?
use tuple to avoid
inner
.Are there any user-facing changes?