-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Establish VISION for "One Layer, All Storage" #5309
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
I also invite all @apache/opendal-committers to join the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One Layer, All Storage 💯
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the concept!
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Co-authored-by: tison <[email protected]>
Co-authored-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. That's great.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. Comments inline.
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
|
||
For example, OpenDAL prefers to have clear and readable code, as this allows more people in the community to join the development. | ||
|
||
### 1. Solid Foundation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 for Solid Foundation
, as mentioned in #5301 (reply in thread)
IMO such a tenet is too big, hollow and subjective to provide guidance meaning and be constructive: no one will ever want to uncarefully build unsolid, untrustworthy software. It is self-evident to me that don't need to be told.
I propose the following alternatives:
Well-defined Behavior
- Or Simply remove this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no one will ever want to uncarefully build unsolid, untrustworthy software. It is self-evident to me that don't need to be told.
This is true. The closest comparison I can think of is the set of safety rules for flying a plane. No one wants the plane to crash, be damaged, or get lost, but that does happen. This principle exists to guide our development so that we don't make changes that lead us off track.
IMO such a tenet is too big, hollow and subjective to provide guidance meaning and be constructive
Yes, I agree that "solid foundation" is somewhat a big word. I'm open to better alternatives.
Well-defined Behavior
This phrase doesn't convey what we want in these areas.
Or Simply remove this one
Unfortunately, I believe we need to emphasize this area. Removing this one might leave our principles incomplete. I still suggest to use solid foundation
if we don't have better one.
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM, solid foundation
seems somehow a vague word, but the explaination after it looks good.
Which issue does this PR close?
Result of #5301
Rationale for this change
Establish VISION for "One Layer, All Storage"
What changes are included in this PR?
Update docs that refer to vision.
Are there any user-facing changes?
Not in the short term, but it will affect the entire future.