ORC-1662: [C++] Upgrade protobuf to 3.21.12 #1857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Unfortunately the new protobuf version is not compatible to compile libhdfspp. Let me investigate this. |
|
Update: I tried to upgrade libhdfspp. But unfortunately, I ran this command https://github.com/apache/orc/blob/main/c%2B%2B/libs/libhdfspp/pull_hdfs.sh#L25 without check. It wiped out my current directory (which is the root user profile). |
|
Oh, too bad for the accident. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade protobuf to 3.21.12
Why are the changes needed?
To fix compilation failure on vs2022
How was this patch tested?
UT passed
Was this patch authored or co-authored using generative AI tooling?
NO