HDDS-12441. Add helper script for building Docker image#39
Merged
adoroszlai merged 5 commits intoapache:masterfrom Mar 4, 2025
Merged
HDDS-12441. Add helper script for building Docker image#39adoroszlai merged 5 commits intoapache:masterfrom
adoroszlai merged 5 commits intoapache:masterfrom
Conversation
dombizita
reviewed
Mar 3, 2025
Contributor
dombizita
left a comment
dombizita
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai, looks good to me! Tested it on my mac and it worked as expected.
dombizita
approved these changes
Mar 3, 2025
Contributor
Author
|
Thanks @dombizita for the review. I plan to update the PR with updated docs as per comment in similar PR for other image. |
Contributor
Author
|
Updated README and CONTRIBUTING docs, please check. |
errose28
reviewed
Mar 3, 2025
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Just minor comments on the markdown but otherwise LGTM.
CONTRIBUTING.md
Outdated
Comment on lines
+52
to
+60
| CI checks are triggered by pushing changes to your fork. | ||
|
|
||
| GitHub Actions workflow runs in your fork are listed at `https://github.com/<username>/ozone-docker-runner/actions`. | ||
|
|
||
| The image is built and tagged with commit SHA in GitHub, ready for testing integration with other repos. | ||
|
|
||
| Images built in your fork are available at `https://github.com/<username>/ozone-docker-runner/pkgs/container/ozone-runner`. | ||
|
|
||
| These images can be shared with other developers for feedback. |
There was a problem hiding this comment.
nit. we can collapse this into one paragraph. I don't think we need one sentence per line.
CONTRIBUTING.md
Outdated
Comment on lines
+71
to
+73
| ## Tagging | ||
|
|
||
| (for committers) |
There was a problem hiding this comment.
Suggested change
| ## Tagging | |
| (for committers) | |
| ## Tagging (for committers) |
CONTRIBUTING.md
Outdated
|
|
||
| (for committers) | ||
|
|
||
| Publishing Docker tags: |
There was a problem hiding this comment.
Can we integrate this line into the section title?
Contributor
Author
|
Thanks @dombizita, @errose28 for the review. |
adoroszlai
added a commit
that referenced
this pull request
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
build.sh, helper script for building the image.Benefits:
ozone-docker*reposAlso add
.dockerignore.https://issues.apache.org/jira/browse/HDDS-12441
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone-docker-runner/actions/runs/13583576812