add unit test protect ExtractEntityId can be shared safely #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roiocam
force-pushed
the
extract-entity-id-protect
branch
from
335dc31 to
08e6722
Compare
…ache#1304) * chore: avoid the double evaluation of entityId in ClusterSharding * new cacheable partial function * optimized for review * fix the right type
Roiocam
force-pushed
the
extract-entity-id-protect
branch
from
08e6722 to
db88f9f
Compare
|
Can we add the unit test independently of the main source changes? |
pjfanning
reviewed
Sep 11, 2024
cluster-sharding/src/test/scala/org/apache/pekko/cluster/sharding/ShardRegionSpec.scala
Outdated
Show resolved
Hide resolved
…ding (#1…" (apache#1464) This reverts commit b0e9886.
Cherry-pick commit is to verify the effective of the unit test |
pjfanning
reviewed
Sep 11, 2024
cluster-sharding/src/test/scala/org/apache/pekko/cluster/sharding/ShardRegionSpec.scala
Outdated
Show resolved
Hide resolved
jxnu-liguobin
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with #1463