feat: Add terminateAndAwait to ActorSystem. #2096
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
terminated
branch
4 times, most recently
from
3380771 to
d4c9d68
Compare
He-Pin
commented
Aug 26, 2025
| import scala.concurrent.Await | ||
| terminate() | ||
| Await.result(whenTerminated, atMost) | ||
| } |
There was a problem hiding this comment.
Added two methods for both Java and Scala
mdedetrich
requested changes
Aug 26, 2025
There was a problem hiding this comment.
Lets hold off merging this for now, main reason is as @raboof stated at #2093 (comment) if we are going to this it makes sense to just call the method close() while implementing the Java closable interface.
|
A close is a |
|
@pjfanning @raboof wdyt？ |
|
Let's see what alternative proposals are made before choosing one. In this PR, I would prefer if the classic ActorSystem terminate was not changed so that existing users won't have a migration problem. |
|
OK, I was alias it with the typed one. |
|
@pjfanning I changed back to the old |
|
@mdedetrich Wdyt, if I change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #2093