Fix pekkoImport() range #2111
Open
Fix pekkoImport() range #2111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The range does not reflect current version, update it to [2,2.1). Signed-off-by: Robert Varga <[email protected]>
He-Pin
approved these changes
Aug 30, 2025
pjfanning
reviewed
Aug 30, 2025
| scalaImport(scalaVersion), | ||
| "*") | ||
| def pekkoImport(packageName: String = "org.apache.pekko.*") = versionedImport(packageName, "1.1", "1.2") | ||
| def pekkoImport(packageName: String = "org.apache.pekko.*") = versionedImport(packageName, "2", "2.1") |
There was a problem hiding this comment.
btw, I'm not sure if we should still keep osgi in 2.0.0, at least Akka dropped it and seems no much complain.
There was a problem hiding this comment.
#705 - but let's assume that that is not agreed yet
|
@rovarga it would be good to keep the version change in its own PR instead of merging other changes here - we may end up cherry picking some changes to other version branches but we can't do that if you change version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The range does not reflect current version, update it to [2,2.1).
Signed-off-by: Robert Varga [email protected]