Skip to content

improve ByteString lastIndexOf #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

improve ByteString lastIndexOf #2153

wants to merge 1 commit into from

Conversation

pjfanning
Copy link
Member

@pjfanning pjfanning commented Sep 5, 2025 •
edited
Loading

  • see Optimise ByteString lastIndexOf #2150
  • WIP
  • doesn't yet use SWAR but having the new methods that take Byte inputs instead of the [B >: Byte] versions is the biggest win
  • needs a jmh benchmark

@pjfanning pjfanning changed the title Last index of improve improve ByteString lastIndexOf Sep 5, 2025
@pjfanning pjfanning marked this pull request as draft September 5, 2025 21:18
@He-Pin He-Pin added this to the 2.0.0-M1 milestone Sep 6, 2025
@pjfanning pjfanning modified the milestones: 2.0.0-M1, 2.0.0-M2 Oct 8, 2025
@pjfanning
ByteStrings impl
b5a4ec5 
add optimised lastIndexOf

Update ByteString.scala

Update ByteString.scala

Update ByteString.scala
@pjfanning pjfanning force-pushed the lastIndexOf-improve branch from fab09a7 to b5a4ec5 Compare October 8, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0-M2

Development

Successfully merging this pull request may close these issues.

2 participants

@pjfanning @He-Pin